Xilinx / mlir-aie

An MLIR-based toolchain for AMD AI Engine-enabled devices.
Other
308 stars 90 forks source link

Add tracing support for Conv2D example #1920

Closed asyms closed 1 week ago

asyms commented 1 week ago

This PR adds support for tracing in the Conv2D example in programming_examples/ml/conv2d.

It updates:

All changes were done accordingly to how the tracing is setup for the programming_examples/basic/vector_scalar_mul.

One caveat: Compilation for Conv2D doesn't function (for me) without adding the AIETOOLS_DIR/include to the programming_examples/makefile-common. Not sure if this is a common issue or if something is wrong on my end regarding my peano install.

asyms commented 1 week ago

Can you please enable testing of the trace functionality in the lit test?

@jgmelber Is this directed at me or Jack because if me I have no idea how to go about this.

jackl-xilinx commented 1 week ago

@asyms I can push the change if you give me permission to push to your branch. For reference, it needs code similar to https://github.com/Xilinx/mlir-aie/blob/main/programming_examples/basic/vector_scalar_mul/run_makefile.lit#L14

asyms commented 1 week ago

@jackl-xilinx Thanks! I have invited you, should have push access once you accept.