search

Xilinx / mlir-air

MIT License
76 stars 26 forks source link

Update for mlir-aie switch to transaction ops #596

Closed fifield closed 4 months ago

fifield commented 4 months ago

update mlir-aie to https://github.com/Xilinx/mlir-aie/pull/1517

fifield commented 4 months ago

@Yu-Zhewen I got a little carried away with what should have been a minor update to the tracing code (for a pending write32 update in mlir-aie) in this PR. See here: https://github.com/Xilinx/mlir-air/pull/596/files/be9ffda4939f69201a1b8115d5b80de76852a2b9..3d372f85f155e2b9935e257aa160167babb80e77, please take a look. I can factor it out into its own PR, but the summary is I tried to make the code verbose/understandable to me by naming the magic constants and factoring out some parts common to the core tile and mem tile.

Yu-Zhewen commented 4 months ago

@Yu-Zhewen I got a little carried away with what should have been a minor update to the tracing code (for a pending write32 update in mlir-aie) in this PR. See here: https://github.com/Xilinx/mlir-air/pull/596/files/be9ffda4939f69201a1b8115d5b80de76852a2b9..3d372f85f155e2b9935e257aa160167babb80e77, please take a look. I can factor it out into its own PR, but the summary is I tried to make the code verbose/understandable to me by naming the magic constants and factoring out some parts common to the core tile and mem tile.

@fifield Thanks! The refactoring does make the code more readable.