search

Xilinx / open-nic-shell

AMD OpenNIC Shell includes the HDL source files
Apache License 2.0
94 stars 63 forks source link

Is the definition of MAC port in "tuser_src" invalid? #54

Closed maswx closed 8 months ago

maswx commented 8 months ago

I noticed that the "s_axis_c2h_tuser_src" in the file "qdma_subsystem_function" is not being used, even though it is described as an interface for describing the source MAC port and source PCIe-PFs in Page10.

Is this a bug?

Similarly, I found that "m_axis_h2c_tuser_src" only operates as follows: "254 assign m_axis_h2c_tuser_src = 16'h1 << FUNC_ID". This means it only operates on PCIe-PFs and doesn't affect MAC ports,which contradicts the description in document P10 where bits[15:6] are supposed to represent MAC ports.

cneely-amd commented 8 months ago

The QDMA subsystem is concerned with the PCIe side and has parts of it organized by FUNC_ID. The CMAC subsystem contains packet_adapter modules specifically: packet_adapter_rx and packet_adapter_tx that are involved in setting and checking the MAC-related portions of the tuser_src and tuser_dst.

maswx commented 8 months ago

Thanks!