search

Xilinx / vcu-ctrl-sw

Other
38 stars 30 forks source link

2020.2 very broken: AL_Assert used with lotsa code that needs retaining despite NDEBUG #4

Open liquidblueocean opened 3 years ago

liquidblueocean commented 3 years ago

https://github.com/Xilinx/vcu-ctrl-sw/blob/b82de3783fe66ee72f28b51313e8b42827d3f202/lib_encode/Com_Encoder.c#L282

This can't be final code for 2020.2. Release builds will disable any code that have AL_Assert around it (by defining NDEBUG) but in too many places the new code expects the condition within the assert to always be there. Above is one of numerous buggy examples.

liquidblueocean commented 3 years ago

The following files have broken assert code added in 2020.2:

src/vendor/vcu-ctrl-sw/lib_common/BufCommon.c src/vendor/vcu-ctrl-sw/lib_common/BufferPixMapMeta.c src/vendor/vcu-ctrl-sw/lib_common_dec/DecBuffers.c src/vendor/vcu-ctrl-sw/lib_decode/DefaultDecoder.c src/vendor/vcu-ctrl-sw/lib_encode/Com_Encoder.c src/vendor/vcu-ctrl-sw/lib_encode/EncSchedulerCommon.c src/vendor/vcu-ctrl-sw/lib_encode/SourceBufferChecker.c

The following were broken in 2020.1 though not everyone is using them:

src/vendor/vcu-ctrl-sw/lib_app/convert.cpp src/vendor/vcu-ctrl-sw/lib_decode/DefaultDecoder.c (ReleaseFramePictureUnused)

I'm guessing Allegro or Xilinx don't do release builds??