Xilinx / xfopencv

Other
329 stars 142 forks source link

Mismatch between xf::Sobel documentation and implementation #31

Closed ghost closed 5 years ago

ghost commented 5 years ago

On page 210 of UG1233 (https://www.xilinx.com/support/documentation/sw_manuals/xilinx2018_3/ug1233-xilinx-opencv-user-guide.pdf), the Sobel filter kernel for the x direction is given as

-3 -10 -3
 0   0  0
 3  10  3

However, this is the Scharr kernel in y direction and the code of xf::Sobel also uses the normal Sobel kernel:

-1 0 1
-2 0 2
-1 0 1

Am I right that this is simply an error in the documentation, and that it is not planned to make the 3x3 Sobel filter (silently) use the Scharr kernel?

I hope that this is the right place for this kind of "bug", sorry if it is not...

bgouthamb commented 5 years ago

Hello @andreasmuetzel-ametek ,

Yes, it is indeed a documentation error. Thanks for pointing it out! Will be correcting it in the next edition of the document.

ghost commented 5 years ago

Great, thank you!