search

Xilmi / OpenXcom

Open-source clone of the original X-Com
http://openxcom.org
GNU General Public License v3.0
19 stars 10 forks source link

Errors in X-Piratez #36

Closed Pirate300 closed 5 months ago

Pirate300 commented 5 months ago

I have encountered two bugs playing X-Piratez:

1- AI doens't use "handle", a weapon of this mod. It makes them only approach without attacking.

2- CTD at certain UFO landing missions. Ending turn just after arriving at certain UFO missions causes the game to crash. I will attach my savegame so you can see what is causing this problem. https://www.mediafire.com/file/798llt1dcoznrjt/ctd.sav/

I have confirmed these bugs don't happen in base OpenXcom

Xilmi commented 5 months ago

Can you check if the crash still happens in current version? It was likely the one introduced in 8.4.0 and fixed in 8.4.1.

The issue with the handle is something I'll still have to look at.

Xilmi commented 5 months ago

I investigated the handle-issue.

The reason that they don't want to use it is due to the damage-type-modifiers. For some reason being hit by a handle restores a ton of morale. So much so, that the AI thinks it would be helping their enemy instead of harming them.

My AI uses some ratios for the damage-types to score the different attack-options. What I hadn't considered is that someone would give weapons negative damage of certain types.

I guess a quick fix would be to ignore these and only consider positive damage-values. A more in-depth-fix would be to simulate the actual effect. A unit with full morale obviously wouldn't benefit from being hit for +858 morale (which is the effect of being hit by the handle with the stats that the soldier I tested it with has).

Xilmi commented 5 months ago

Workaround available in 8.5.1:

If a weapon causes negative damage to armor, morale, energy, mana or time-units, this effect is now ignored in the damage-type-modifier of the AI-score for using that weapon.