[0.9.1] Main window won't minimize when clicking on close.

Ximi1970 / systray-x

SysTray-X: A system tray extension for Thunderbird. Needs both the addon AND the companion app installed to work. Will not work with TB flatpaks or snaps.

Mozilla Public License 2.0

217 stars 14 forks source link

[0.9.1] Main window won't minimize when clicking on close. #122

Closed lgbaldoni closed 2 years ago

lgbaldoni commented 2 years ago

Describe the bug Clicking on the close button won't elicit any response.

To Reproduce

Install 0.9.1 from home:Ximi1970:Mozilla:Add-ons/systray-x
Run Thunderbird
Click the close button

Expected behavior The window disappearing

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: openSUSE Linux Leap 15.4
Architecture 64 bit
Desktop type / Window Manager KDE Plasma5
Thunderbird version and arch Thunderbird 91.11.0 x86_64
Run echo $XDG_SESSION_TYPE in a terminal and report the results x11
Add-on version 0.9.1
App version n/a
Install type: OBS repository
Used Qt library 5.15.2 from system repository

Additional context Add any other context about the problem here.

Ximi1970 commented 2 years ago

Is the titlebar disabled?

Ximi1970 commented 2 years ago

I get the error message "Window listener for extension + 'closeButtonListener' already registered" ttilebar disabled and logiing in. When I quit and start TB again it works.

lgbaldoni commented 2 years ago

I get the error message "Window listener for extension + 'closeButtonListener' already registered" ttilebar disabled and logiing in.

Sorry, where? Should I open a debug window or something?

Ximi1970 commented 2 years ago

Titlebar: In Tb -> Open the menu -> View -> Toolbars -> Toolbat Layout... -> Left bottom, checkbox Titlebar. Debug: In Tb -> Open the menu -> Tools -> Developer Tools -> Error console And / or: Tb -> Open the menu -> Tools -> Developer Tools -> Debug Addons -> Select the "Inspect of SysTray-X -> console tab

lgbaldoni commented 2 years ago

Nothing happens in the debug console whenever I click on close.

Ximi1970 commented 2 years ago

Could you try the package in this repo:

sudo zypper ar -f https://download.opensuse.org/repositories/home:/Ximi1970:/Mozilla:/Add-ons:/Staging:/Test3/15.4/ SysTray-X-Test3 sudo zypper in systray-x

Make sure this version is installed: systray-x-0~git20220711.bc9df9a-150400.30.1.x86_64.rpm

I removed an old? call. There is still an error thrown when disabling the add-on but that seems to have no impact.

lgbaldoni commented 2 years ago

systray-x-0~git20220711.bc9df9a-150400.30.1.x86_64.rpm

Much better, thanks!

Ximi1970 commented 2 years ago

Nice! will merge the code to develop and.....new release again :-)