search

Ximi1970 / systray-x

SysTray-X: A system tray extension for Thunderbird. Needs both the addon AND the companion app installed to work. Will not work with TB flatpaks or snaps.
Mozilla Public License 2.0
213 stars 15 forks source link

Support the new version of Thunderbird 115.0+ #147

Closed giwrgosmant closed 12 months ago

giwrgosmant commented 1 year ago

Describe the bug The current version of systray-x is incompatible with the new release of Thunderbird 115.0+.

Desktop (please complete the following information):

Antiz96 commented 1 year ago

For information, I opened a related pull request: #148

giwrgosmant commented 1 year ago

For information, I opened a related pull request: #148

Thx, hopefully @Ximi1970 will be able to merge it soon 🤞

Antiz96 commented 1 year ago

Well, support for Thunderbird 115+ has been added and a new tag has been created. My pull request has been ignored though, I guess I'll just close it ^^

This issue can be closed as treated however :)

Ximi1970 commented 1 year ago

Addon is now allowing even 116. Seems it all still works (just a quick test) Released a new version.

giwrgosmant commented 1 year ago

Addon is now allowing even 116. Seems it all still works (just a quick test) Released a new version.

Hi, Thanks for didn't abandon the project 🤗 I can't live without it!

I tried the SysTray-X-setup64-0.9.3.exe which you released few minutes ago, I did clean install both Thunderbird v115.0 and SysTray-X but SysTray-X doesn't seem to work at all. I installed SysTray-X as "just for me" not "for all users". Nothing happens when I install it, it doesn't appear inside Thunderbird as addon etc.

Any idea? 🤔

Ximi1970 commented 1 year ago

Had problems upgrading in Windows a year ago. Thought I sovled it.... Will have a look again. Please try this:

https://github.com/Ximi1970/systray-x/issues/106#issuecomment-942025138

giwrgosmant commented 1 year ago

Had problems upgrading in Windows a year ago. Thought I sovled it.... Will have a look again. Please try this:

#106 (comment)

I've managed to make it work by manually installing the .xpi file in Thunderbird as you described in the link you mentioned. Thank you 🤗 Btw, one thing I noticed, is the default path of systray-x folder changed from C:\Users\User1\AppData\Local to C:\Users\User1\AppData\Local\Programs. It was intentionally? Also the default icon of Thunderbird(systray-x) in tray, is still the old one and not the new one, is it possible to change it? OLD: 2023-07-16 14_59_13-

NEW: 2023-07-16 15_03_40- I tried the option with a custom icon and I selected the new icon from the thunderbird folder, but seems very small.

Ximi1970 commented 1 year ago

I saw the icon change to late... I will update the icon and double check the Windows installer script.

koroki commented 1 year ago

Simply, thanks for the update. Works properly in Arch linux + gnome (thunderbird working in xwayland).

Antiz96 commented 1 year ago

@Ximi1970 Do you mind creating a new tag once done so new binaries can be built including the new icon?

Ximi1970 commented 1 year ago

New version with new the icon for >115 and separate actions are possible now for minimize, close and icon click.

Antiz96 commented 1 year ago

@Ximi1970 Thanks, works as expected on Arch!

giwrgosmant commented 1 year ago

New version with new the icon for >115 and separate actions are possible now for minimize, close and icon click.

Unfortunately the new version 0.9.4 doesn't work on Windows 11. I mean the installation works ok now, (the path changed to C:\Program Files instead of User/AppData tho) and the extension appears in Thunderbird to enable it. However upon enable it doesn't work at all, no icon on tray and you can't close the window of Thunderbird with "X" only to minimize it with the minimize button. Back to 0.9.3 with the workaround for the moment. 🙁

Ximi1970 commented 1 year ago

Needed to update my VMs a bit, but Windows 11 works just fine with a clean install. The old installer was a bit of a disaster, sorry..., and cannot be uninstalled if you used the single user install. You need to manually remove the SysTray_X directory from the C:\Users\\AppData\Local\Programs\ dir and remove the addon in Thunderbird in the Add-ons and Themes, extensions dialog. Then you can use the new installer.

giwrgosmant commented 1 year ago

Needed to update my VMs a bit, but Windows 11 works just fine with a clean install. The old installer was a bit of a disaster, sorry..., and cannot be uninstalled if you used the single user install. You need to manually remove the SysTray_X directory from the C:\Users\\AppData\Local\Programs\ dir and remove the addon in Thunderbird in the Add-ons and Themes, extensions dialog. Then you can use the new installer.

Yeap, I always do clean install on updates and I manually deleting the systray-x directory from AppData. The installation was fine as I said but the problem was/is with the functionality of the app. Unfortunately it doesn't work properly for me 😕 I will try once again tomorrow and I will let you know.

giwrgosmant commented 1 year ago

@Ximi1970 Sorry for the delay, I clean install the latest version 0.9.4 again but still doesn't work properly. Back to v0.9.3 with the workaround of the manual installation of .xpi working fine.

DSDV commented 1 year ago

when i want to install this addon on fedora 38 it wants to install thunderbird (102) as well. But thunderbird 115 (flatpack is already installed and running :(

i think something is not working

Ximi1970 commented 1 year ago

Please upgrade your addon to version 0.9.4. I am not able to block installing a newer TB version under Windows(tm)(c) because the addon does not support it. Most of the time it is just that I did not check the functionality yet and released a new version. Under linux the package will block all newer TBs automaticly when not supported / not checked.

DSDV commented 1 year ago

image @Ximi1970 my problem seems reversed :/

Ximi1970 commented 1 year ago

No, your problem is using flatpak. This is a sandboxed TB application and probably will not work with an externally installed TB addon. The flatpak is not registered by the system and does not use the system dependency to operate. If you really want to use a flatpak contruction you need a flatpak with TB and an installed systray-x addon. And even then I do not know if this will work. The flatpak needs a lot of access to the system to get systray-x working.

But may I ask why you are using a flatpak while there is a perfectly working TB in the repository?

DSDV commented 1 year ago

Oh so systray-x is not compatible with flatpak?

But may I ask why you are using a flatpak while there is a perfectly working TB in the repository?

because its flatpak? Thunderbird is not a program which needs some deep system access like my kvm/qemu. Therefor its going to be a flatpak. If you ask the question of direct install vs flatpak i dont want to derail this issue into a apple/android war scenario ;) For me personally everything not requiring deep system level access has to be a flatpak which i than additionally can control with flatpak seal (:

//PS: iirc flatpak is the preferred distribution method for TB as of 115. And 115 is not yet in the repos :/

If it’s convenient for you, we recommend installing the Thunderbird Flatpak from Flathub, which is now packaged and maintained by the Thunderbird team.

Source: https://blog.thunderbird.net/2023/07/our-fastest-most-beautiful-release-ever-thunderbird-115-supernova-is-here/

Ximi1970 commented 1 year ago

No, flatpak is not compatible with SysTray-X. Tried to install the addon manually. The addon installed without any problems but TB can not find the companion app. The TB flatpak will not read the default "native-messaging-hosts" directories anywhere on the system. Not in /usr/lib64/mozilla, not in the user dir ~/.mozilla and not in the flatpak dirs ~/.var/app/org.mozilla.firefox (or app/org.mozilla.Thunderbird which is not standard). The TB flatpak is not compatible with the native messaging / application api of mozilla itself. If you can find the right directory, please let me know.