The StateDB type utilizes a dbErr to track database errors. It is employed by both the consensus core and the VM which are not designed to manage such errors directly.
Errors encountered during database operations are recorded in dbErr using the SetError function. During a Commit, functions like deleteStateObject, updateStateObject, and getStateObject are called based on the current state of stateObject to manage trie node data for deletion, update, or retrieval. If a data node is missing, dbErr is set accordingly.
To avoid committing erroneous state, check the dbErr before performing Commit action.
Proposed changes
The StateDB type utilizes a dbErr to track database errors. It is employed by both the consensus core and the VM which are not designed to manage such errors directly.
Errors encountered during database operations are recorded in dbErr using the SetError function. During a Commit, functions like deleteStateObject, updateStateObject, and getStateObject are called based on the current state of stateObject to manage trie node data for deletion, update, or retrieval. If a data node is missing, dbErr is set accordingly.
To avoid committing erroneous state, check the dbErr before performing Commit action.
This issue is raised by the auditing team ref: https://github.com/ethereum/go-ethereum/pull/21039/files, https://github.com/ethereum/go-ethereum/pull/21051
This is re-open of https://github.com/XinFinOrg/XDPoSChain/pull/484 which was reverted with https://github.com/XinFinOrg/XDPoSChain/pull/489.
The auditing team provided further fixing to the issue: https://github.com/ethereum/go-ethereum/pull/21051
Types of changes
What types of changes does your code introduce to XDC network? Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that