search

Xinayder / yabpt

Chrome and Firefox extension that displays the current price of Bitcoin, in a wide range of currencies.
GNU General Public License v3.0
5 stars 17 forks source link

Determination of language by currency won't work #16

Closed jschram closed 6 years ago

jschram commented 6 years ago

in background.js the translation is determined by the selected currency. This brings up issues for users that select EUR as their currency, since this currency is shared by many countries, each with their own languages.

It would be better to have the code use the browser's preferred language, if it's available. This preferred language can be easily read from window.navigator.languages

Xinayder commented 6 years ago

I was thinking about this just yesterday, I don't know what went in my head when I wrote that code.