Xinbingru / COFsMembraneML

A machine learning implementation of an interpretable model for membrane separation performance prediction of COFs materials.
3 stars 0 forks source link

About diffusion coefficient #1

Closed Yong-Q closed 1 month ago

Yong-Q commented 1 month ago

Surprisingly, it is found that the diffusion coefficient can be predicted very well by the structural coefficients such as the aperture, and other characteristics seem to be not so important, which does not seem to be very consistent with previous studies. Machine learning algorithms are also commonly used classical algorithms.

Xinbingru commented 1 month ago

In fact, the diffusion coefficient is less accurate than the adsorption properties, but we chose the ML model with relatively high accuracy to calculate the SHAP values of the features. If you only use structural features such as pore size to predict the diffusion coefficient, you will get much lower accuracy and correspondingly less reliable SHAP values.

Yong-Q commented 1 month ago

Ok, I will replicate this work in other data sets as soon as possible

Xinbingru commented 1 month ago

No problem at all. Feel free to talk to me if you have any questions. Of course, it would be great if you could cite my work : )

Yong-Q commented 1 month ago

If possible, can you share a batch processing script to get the required features? This may greatly improve the speed at which others replicate the work. thank you!

Yong-Q commented 1 month ago

This may not include the calculation of the diffusion coefficient or the calculation of adsorption selectivity, although it would be better if both were included.

Xinbingru commented 1 month ago

If possible, can you share a batch processing script to get the required features? This may greatly improve the speed at which others replicate the work. thank you!

In fact, you can find the algorithms for each descriptor in my paper's supporting information.In addition, you can also find some scripts on Github for information extraction of CIF files, I hope this will help you.