XinghuaJulia / pe

0 stars 0 forks source link

Duplication handling does not consider email and phone number. #9

Open XinghuaJulia opened 4 days ago

XinghuaJulia commented 4 days ago

Description Duplication of email and phone number is allowed.

Steps to reproduce error:

  1. Open the .jar application
  2. Type edit s1234567a p/ 99272758 (this is a duplicate phone number of the sample contact Bernice Yu)

bug10.png

Expected Output A warning/error message that says you cannot edit the person to have duplicate email/phone number.

Actual Output The command goes through.

Reason for severity Medium. It is uncommon for 2 patients to have the same phone number. Thus, when such cases happen, it is likely due to a typo. Hence, the application should warn the user that there is a duplicate phone number :,)

nus-se-bot commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

We appreciate the concern about potential typographical errors leading to unintended duplication of contact information. However, we believe that allowing duplicate phone numbers or emails is beneficial for the following reasons:

Future Improvement

We will make this clearer in the User Guide about why this is an intended feature in the future. This will help users understand the rationale behind allowing duplicate contact details and avoid potential confusion :'(

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]