Open XinghuaJulia opened 4 days ago
[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
We appreciate the concern about potential typographical errors leading to unintended duplication of contact information. However, we believe that allowing duplicate phone numbers or emails is beneficial for the following reasons:
Phone numbers and emails are sometimes shared between multiple individuals. For example:
Avoiding Overzealous Input Validation: Restricting contact information to unique values only could lead to frustrations, who may intentionally use duplicate values across different patients for valid reasons.
User Responsibility: We believe that users should review their inputs for accuracy, especially in cases where contact information is shared. Typographical errors can be mitigated by user vigilance.
We will make this clearer in the User Guide about why this is an intended feature in the future. This will help users understand the rationale behind allowing duplicate contact details and avoid potential confusion :'(
Team chose [response.NotInScope
]
Reason for disagreement: [replace this with your reason]
Description Duplication of email and phone number is allowed.
Steps to reproduce error:
edit s1234567a p/ 99272758
(this is a duplicate phone number of the sample contact Bernice Yu)Expected Output A warning/error message that says you cannot edit the person to have duplicate email/phone number.
Actual Output The command goes through.
Reason for severity Medium. It is uncommon for 2 patients to have the same phone number. Thus, when such cases happen, it is likely due to a typo. Hence, the application should warn the user that there is a duplicate phone number :,)