Xinoi / DNASIC

Little SpaceGame for IT-Project
GNU General Public License v2.0
1 stars 0 forks source link

Main Menu Music #26

Closed Xinoi closed 2 years ago

Xinoi commented 2 years ago

i think it is a good idea to use the main menu music (Rebel?) in all Menu Screens(level, settings) cause it sounds hella fire and it is smoother. Other games usually have only one menu music too

Xinoi commented 2 years ago

it kinda disturbs the flow to have 2 different songs

itsSanoi commented 2 years ago

That is a good pint but the music is insane we have to use the music in a other part of the game

Jan130 commented 2 years ago

Good point. I might implement some kind of audio player later so the song doesn't restart every time you switch screens.

itsSanoi commented 2 years ago

i think that shuld fix it

Xinoi commented 2 years ago

its probably possible without some extra player. I had an issue that the music kept playing even though i changed screen. I fixed it by stopping it in the hide() method. If we dont do that we simply have to stat the music in the main menu Screen and dont even have to create new Music objects and playing them in other screens

Xinoi commented 2 years ago

but i guess an audio manager is the more sublime solution. Probably better for later if we have to play music and sounds more frequently

Jan130 commented 2 years ago

its probably possible without some extra player. I had an issue that the music kept playing even though i changed screen. I fixed it by stopping it in the hide() method. If we dont do that we simply have to stat the music in the main menu Screen and dont even have to create new Music objects and playing them in other screens

The problem with this is that we will not be able to stop the music later since the object we would need to use would be on another screen...

Jan130 commented 2 years ago

Just tried implementig it on a new branch but couldn't get it to work. If anybody has a good idea how to get it to work you could just try :-)

Xinoi commented 2 years ago

what did you try ?

Jan130 commented 2 years ago

I tried creating a MusicPlayer class and creating an instance of it in the Game class and calling the methods from the screens, but the music didn't play.

Xinoi commented 2 years ago

K im gonna try creating a music player some time