search

Xinyuan-LilyGO / T-Display-S3

MIT License
733 stars 174 forks source link

Shouldn't User_Setup.h file point to one of the ST7798 drivers #132

Closed reflectingme closed 1 year ago

reflectingme commented 1 year ago

I see in the User_Setup.h file, the default driver is IKI9341, but the T-Display board uses the ST7789 driver. So, shouldn't this file (and any associated files) be updated to utilise the correct TFT driver files?

There are two ST7789 driver files, which one should be default please?

Thanks

lewisxhe commented 1 year ago

https://github.com/Xinyuan-LilyGO/T-Display-S3/blob/bed92790ebcfd54de0fd6dd883c88e2791345bd1/lib/TFT_eSPI/User_Setup_Select.h#L131

reflectingme commented 1 year ago

Hi Lewis

Yes I see that for sure, but that is in the User_Setup_Select.h file

I am referring to the entry in the User_Setup.h file where the TFT drivers are defined and selected. There are two ST7789 driver lines but despite the T-Display using the ST7789 driver, they are not selected in that file.