Xinyuan-LilyGO / T-Display-S3

MIT License
731 stars 173 forks source link

Merge changes to TFT_eSPI upstream #192

Closed alranel closed 2 months ago

alranel commented 9 months ago

Hello! At the moment, a modified copy of the TFT_eSPI library is shipped in this repository that users have to manually install in their libraries folder replacing the original TFT_eSPI library. As of today, the upstream library does not seem to work with the examples provided here for T-Display-S3.

This creates multiple issues:

Could you consider making a pull request to the original library with your changes so that users can just install the original TFT_eSPI library from the Arduino IDE instead of having to replace it with this modified copy?

As an alternative, if you don't think a pull request is feasible, I strongly recommend to consider moving your library to its own repository and call it with an alternative name like "TFT_eSPI_LilyGo" or "TFT_eSPI_TDisplayS3" so that it can be installed from the Arduino IDE (much better experience for your customers!) and does not collide with the original one.

Thank you :)))

lewisxhe commented 8 months ago

The upstream TFT_eSPI has added the configuration file of T-Display-S3 and can be upgraded directly. However, after the upgrade, the configuration of T-Display-S3 needs to be re-enabled.

lyusupov commented 8 months ago

consider making a pull request ...

The upstream TFT_eSPI has added the configuration file of T-Display-S3 ...

https://github.com/Bodmer/TFT_eSPI/pull/2317

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 2 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.