search

Xinyuan-LilyGO / lilygo-micropython

Micropython for LILYGO boards
GNU General Public License v3.0
101 stars 30 forks source link

Fixed a relative path refernce in a cmake file. #37

Open jdownie opened 1 year ago

jdownie commented 1 year ago

I was unable to compile in my machine without this change. Hopefully this is a sensible change to offer upstream.

MrDolch commented 1 year ago

I faced the same problem and this commit solved it. Big thanks to @jdownie

He-Peter-Huang commented 12 months ago

Yes, this fixed the issue. Please merge into main branch.

jdownie commented 11 months ago

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

lbuque commented 11 months ago

@jdownie The problem you encountered may be caused by the incorrect commit id of lcd_binding_micropython. You can try to use https://github.com/lbuque/micropython-builder

He-Peter-Huang commented 11 months ago

Is there something else i could or should do to help this into the upstream project @He-Peter-Huang ?

I tried pulling micropython to the latest build, no luck, encountered a couple of errors. Could someone try to bump it to the latest version? The new mip seems a lot friendlier than the old upip.

jdownie commented 11 months ago

Thanks for the suggestion @lbuque . I think that this means that my solution might have yielded a positive result and helped @He-Peter-Huang , but it's not addressing the root cause. I think @He-Peter-Huang and I are keen to see my PR rejected and the other branch that you volunteered merged so that people like us get the best available version by default instead of getting lost among these branches. Have you submitted a PR for your solution?

lbuque commented 11 months ago

@jdownie Please check out #35