TODO - Githubissues

XiongAmao / vue-easy-lightbox

A tiny lightbox component for Vue.js 3.0 :tada::tada: https://xiongamao.github.io/vue-easy-lightbox/

MIT License

409 stars 68 forks source link

TODO #11

Closed XiongAmao closed 3 years ago

XiongAmao commented 5 years ago

[x] Custom toolbar/btns/ options #5
[x] Description text #9
[x] Rewrite class name
[ ] New document ( vuePress ?)
[x] Mobile support #4
[x] Minimize bundle size #12
[x] Provide es5 / es6+ #12
[x] Img loading.
[x] escape pressing
[x] TypeScript support
[x] Rewrite to TypeScript
[x] Minize TypeScript build size (with babel)
[ ] Customize Styles support
[x] Error handler
[ ] Refactor with tsx
[x] btn click event & index change event

mohyM commented 4 years ago

add callback listener to next and previous button to do function like (load more images from server ) I think it will be very useful

XiongAmao commented 4 years ago

Hi, @mohyM I add events(on-prev-click/on-next-click/on-index-change) in v0.11.0 . You can also use slot to customize btn to implement the same feature.

mohyM commented 4 years ago

@XiongAmao please help me how can I use these events(on-prev-click/on-next-click/on-index-change) on a component to do something please help :)

XiongAmao commented 4 years ago

@mohyM I made a demo https://github.com/XiongAmao/vue-easy-lightbox/blob/master/demos/event-handler/src/App.vue

mohyM commented 4 years ago

@XiongAmao thanks for your efforts but i have another idea to create list of thumbnails of image that preview index of image and all images at bottom of the screen

XiongAmao commented 4 years ago

@mohyM I don't plan to develop this feature for now , maybe latter. Welcome PR.

mohyM commented 4 years ago

@XiongAmao Thanks for your reply, I can help you to implement this feature if you want thanks, bro