feat: add default mac menu bar items

Xiphe / budgetbudget

🧮 make financial decisions with confidence

https://budgetbudget.app

GNU General Public License v3.0

93 stars 7 forks source link

feat: add default mac menu bar items #85

Closed leo-benz closed 2 years ago

leo-benz commented 2 years ago

Add default 'Window' menu
Add help menu with links to github issues and wiki

Closes #83

Xiphe commented 2 years ago

Cool! Thanks for the PR.

(And also sorry for not really working on this lately :/)

Xiphe commented 2 years ago

the release did not went through :/

Will look into that within the next days

leo-benz commented 2 years ago

I checked the build log and noticed that I faced the same issue locally when packaging a build. I traced it down to an incompatibility between ts-loader and webpack (see https://github.com/TypeStrong/ts-loader/issues/595). By updating CRA to the next version (see https://github.com/facebook/create-react-app/discussions/11278) it was fixed. I did not commit these changes because I thought it is a local issue and I don't know if updating CRA has any side effects.

Xiphe commented 2 years ago

Ah awesome! Thanks for sharing. Will try that later today

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0-beta.18 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: