search

Xippo / OM-Cookie-Manager

TYPO3 Extension - OM Cookie Manager | Feats: Consent Panel (Optin), Grouping and Google Tag Manager support
GNU General Public License v3.0
10 stars 9 forks source link

[BUGFIX] Fix failing TS constants replacement in HTML #12

Closed DrWh0286 closed 3 years ago

DrWh0286 commented 3 years ago

The method used for this is protected now, so it can not be used anymore. Quick fix was to copy the logic for replacing the the constants from TemplateService and do the replacement in the extension.

Resolves #11

DrWh0286 commented 3 years ago

@Xippo Hi :-), can you tell me the current state of this please?

baschte commented 3 years ago

Hey @Xippo, we would love to have this fix in the current version of your extension :-) thank you

Xippo commented 3 years ago

Sorry guys for keeping you waiting so long ... over the christmas and new year vacation i will spend some time on the extension and i will fix this issue or better merge the changes.

Am Mo., 14. Dez. 2020 um 11:40 Uhr schrieb DerBasti < notifications@github.com>:

Hey @Xippo https://github.com/Xippo, we would love to have this fix in the current version of your extension :-) thank you

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Xippo/OM-Cookie-Manager/pull/12#issuecomment-744350929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7ETWFAC62UIWAN3RKQXMLSUXTSXANCNFSM4QE7OUJQ .

baschte commented 3 years ago

Sorry guys for keeping you waiting so long ... over the christmas and new year vacation i will spend some time on the extension and i will fix this issue or better merge the changes. Am Mo., 14. Dez. 2020 um 11:40 Uhr schrieb DerBasti < notifications@github.com>: … Hey @Xippo https://github.com/Xippo, we would love to have this fix in the current version of your extension :-) thank you — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7ETWFAC62UIWAN3RKQXMLSUXTSXANCNFSM4QE7OUJQ .

Hi @Xippo, happy new year 🎉 do you have any news for this bugfix?

greetings

Xippo commented 3 years ago

I have setup my brand new test enviroment (based on wsl2 docker) setting and have tested the functionality from TYPO3 7 to 10 and it works fine.

@maritwho thanks for your contribution