search

Xippo / OM-Cookie-Manager

TYPO3 Extension - OM Cookie Manager | Feats: Consent Panel (Optin), Grouping and Google Tag Manager support
GNU General Public License v3.0
10 stars 9 forks source link

TYPO3 11 and 12 support #26

Closed baschte closed 8 months ago

baschte commented 8 months ago

Hey Olli, here you find the PR for TYPO3 11 and 12 LTS support. If you have some optimizations let me know and we find a solution :-)

Hope you find the time to check and release a new version. i changed the version to 12 in ext_emconf.

best regards Basti

Xippo commented 8 months ago

@baschte is there a reason to set \OM\OmCookieManager\Controller\CookiePanelController::class => 'show' as non cachable? The hooks Classes/Hook/ProcessCmdmapClass.php and Classes/Hook/ProcessDatamapClass.php should clear the caches when data changes are made inside the backend and the default settings are set.

baschte commented 8 months ago

Hey @Xippo Yes, if I put a JavaScript behind a checkbox, for example, which must be executed directly after activation, this worked directly. If I then deactivated this checkbox again, the script was still executed because it was still in the cache. Through the non cachable action this is immediately correct and always up to date.

Xippo commented 7 months ago

During the development i have tested the extension setting "Clear Frontend Cache after Panel or Group Changes" which is enabled per default. This will clear the pages cache when updates, deletions happen or new panels or groups are setup. I have reverted the no cache for performance reason. Maybe in your setup sendCacheHeaders was active?