search

Xippo / OM-Cookie-Manager

TYPO3 Extension - OM Cookie Manager | Feats: Consent Panel (Optin), Grouping and Google Tag Manager support
GNU General Public License v3.0
10 stars 9 forks source link

Multidomain setup #8

Open opaque01 opened 3 years ago

opaque01 commented 3 years ago

On a multidomain website with diverent storage folders all cookie groups are visible in available groups. Change line 164 to

'foreign_table_where' => 'AND tx_omcookiemanager_domain_model_cookiegroup.pid=###CURRENT_PID### AND tx_omcookiemanager_domain_model_cookiegroup.sys_language_uid = ###REC_FIELD_sys_language_uid###',

and only the cookie groups of the current pagetree are visible.

Xippo commented 3 years ago

Thx for your input. With this change you will be able to select only the groups which are stored on the same pid. For all my setups this will be fine, but im not 100% sure if there is some kind of edge case where this will be a issues. For example if we have a global folder outside of the different domain trees, where we store all kind of groups, and inside of each domain we setup a panel with the needed groups only. This will not work anymore. But from user view this change makes sense. I will add this change to the next version and see if there are complaints against. Maybe a change to a group field would be a good way to go.

//EDIT Evaluating options to improve this. Im looking for a better solution to limit the option to the storage folder and his childs. Alternatively the selection can be done over a specific entry browser (TCA Group field)