Xithrius / twitch-tui

Twitch chat in the terminal.
https://xithrius.github.io/twitch-tui/
Apache License 2.0
451 stars 32 forks source link

Uneven margins with only chat messages #599

Closed calebaden closed 5 months ago

calebaden commented 5 months ago

Describe the bug:

Trying to achieve a minimal chat window results in empty space on the top and bottom of screen because the chat area does not update when the options title_shown and state_tabs are disabled and when not in insert mode.

To Reproduce:

  1. Set title_shown = false in config
  2. Set state_tabs = false in config
  3. Join any chat lobby in twt
  4. Observe empty lines on top and bottom of window when not in insert mode

Expected behavior:

Chat messages should use entire area of terminal like other terminal applications.

Screenshots:

2024-05-17-082154_hyprshot 2024-05-17-081755_hyprshot

System:

Additional context: Add any other context about the problem here.

Xithrius commented 5 months ago

Thanks for the issue! I'll see what I can do to fix this.

Xithrius commented 5 months ago

Did you happen to modify the config variable hide_chat_border? I managed to forget to put it in the default config in the repository, although it should be there when generating a local config. This doesn't solve your issue, I'm just making sure.

calebaden commented 5 months ago

Yes, it was there when I generated a local config and I changed it to true

Xithrius commented 5 months ago

Alright, thanks. I've narrowed down where the issue is occurring, I'll just need to fix it.

Xithrius commented 5 months ago

Fixed, available in the release linked below. Feel free to reopen this issue if it's still broken.

https://github.com/Xithrius/twitch-tui/releases/tag/v2.6.9