Correctly handle paginated response for twitch user emotes

Xithrius / twitch-tui

Twitch chat in the terminal.

https://xithrius.github.io/twitch-tui/

Apache License 2.0

437 stars 32 forks source link

Correctly handle paginated response for twitch user emotes #616

Closed Nogesma closed 2 months ago

Nogesma commented 2 months ago

Fixes #615

This is a very quick fix, let me know if it works. I disabled fetching global emotes for twitch as it should now be handled by the get_user_emotes part. If it works correctly I'll do a bit of cleanup before merging.

Xithrius commented 2 months ago

I'll be able to test later today (6 hours or so), thank you very much for the quick PR.

Nogesma commented 2 months ago

Please make sure your token has the user:read:emotes scope. I think I have a warning in the log file if the query fails because of that. If that's not it I can try to look into it further tomorrow.

Nogesma commented 2 months ago

Ah sorry I already did it, it's good to merge.

Xithrius commented 2 months ago

Very cool. Thanks!