search

Xithrius / xithrius.cloud

Personal portfolio website.
https://xithrius.cloud/
MIT License
1 stars 3 forks source link

respect system preference changes always #180

Closed hedyhli closed 5 months ago

hedyhli commented 9 months ago

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

yes I am always frustrated when my eyes are blinded by the light theme when my device automatically switches to dark mode at dusk but your site does not change. this is important because I might be reading your blog posts in the day, having put it off, continue reading at night. your visitors might be whisked away if the blinding lights annoyed them.

Describe the solution you'd like

A clear and concise description of what you want to happen.

it must follow system changes! (even after I've clicked on the toggle button to preview how to site looks like in both modes)

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

python-discord/site#1176 see example implementation :D

Additional context

Add any other context or screenshots about the feature request here.

surrender to the pressures of modern web UX standards! /s

this should be a bug report instead. oops.

by the way I like that you also practice competitive programming cses is also a great site in addition to the ones you mentioned.

by the way 2, you can add labels to your issue templates so all feature/bug issues get the corresponding labels automatically

Xithrius commented 9 months ago

homer

Xithrius commented 8 months ago

@hedyhli I believe the issue has been fixed. Are you still experiencing it?

hedyhli commented 8 months ago

nup it's still the same

it must follow system changes! (even after I've clicked on the toggle button to preview how to site looks like in both modes)

I mentioned last time in discord about dark/light vs 'system' so issue is probably here

https://github.com/Xithrius/xithrius.cloud/blob/f40777df3fdfe0bb66dd632cb64309600a33f663/site/components/App/ThemeToggle.vue#L9

but in that case I can't think of any good solutions, so if you do manage to fix it it'd be amazing and impressive

Xithrius commented 8 months ago

I will think with brain more

Xithrius commented 5 months ago

ok I fixed it

hedyhli commented 5 months ago

good solution!!

El dom, 12 may 2024, 11:17, Xithrius @.***> escribió:

ok I fixed it

— Reply to this email directly, view it on GitHub https://github.com/Xithrius/xithrius.cloud/issues/180#issuecomment-2106102559, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL5ZJUSBPNJLUDVLUYT4QDLZB3NLVAVCNFSM6AAAAABCLW7HJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGEYDENJVHE . You are receiving this because you were mentioned.Message ID: @.***>