github_issue_converter.py also imports comments which are marked as deleted

[GoogleCodeExporter]

What steps will reproduce the problem?

Have an issue with deleted comments, like 
https://code.google.com/p/tortoisegit/issues/detail?id=48, comment #16 is 
deleted

What is the expected output? What do you see instead?

This comment must not be migrated. - It is migrated.

Original issue reported on code.google.com by sstrickr...@googlemail.com on 11 Apr 2015 at 4:46

[GoogleCodeExporter]

This is by design. Without creating placeholder "deleted issues", the issue 
numbering between Google Code and GitHub will not match. Since it is possible 
to reference issues within a comment, (e.g. "this is issue #72 on Google Code") 
we opted to migrate the deleted issues so the issue converter script didn't 
also need to scan/modify issue contents as well.

Otherwise issue links within the comment text would go to the wrong issues.

Original comment by chrsm...@google.com on 11 Apr 2015 at 5:13

• Changed state: Invalid

[GoogleCodeExporter]

This is not about deleted *issues* its about deleted *comments* in an issue.

These comments might be deleted intentionally by the poster, e.g. becasue those 
included confidential data.

Original comment by sstrickr...@googlemail.com on 11 Apr 2015 at 5:22

Attachments:

• 0001-Ignore-deleted-comments.patch

[GoogleCodeExporter]

After re-reading your comment I'm again confused: You don not create "dummy 
issues" in github_issue_converter.py. - I cannot use your "Export to GitHub" 
button as my project has more than 2K issues... 

Original comment by sstrickr...@googlemail.com on 11 Apr 2015 at 5:24

[GoogleCodeExporter]

Oh I see now. My mistake.

Yes, do not see a reason to recreate deleted comments.

Original comment by chrsm...@google.com on 11 Apr 2015 at 5:30

[GoogleCodeExporter]

Original comment by chrsm...@google.com on 26 Apr 2015 at 1:14

• Changed state: Accepted
• Added labels: Component-ExporterScripts