search

Xjph / ObservatoryCore

Elite Observatory: Extensible tool for processing Elite Dangerous journals
https://observatory.xjph.net/
MIT License
84 stars 16 forks source link

Enhancement request: add default criteria for inclined+nearby moons of ringed planets & for planets very close to their stars #126

Open Starfire70 opened 11 months ago

Starfire70 commented 11 months ago

Inclined moons that are near their ringed gas giant and planets that are near their parent star can be great tourist stops for the view. Here's what I added to my custom file to cover these.

::Proximity:: scan.Landable and scan.DistanceFromArrivalLS < 20 ;the only problem with this is that it won't detect close proximity planets around companion stars ;using semi-major access also triggers for moons around planets which I don't want

::Criteria:: if scan.Landable and scan.OrbitalInclination > 5 and scan.OrbitalPeriod < 2600000 and parents then if parents[0].Scan and parents[0].ParentType == 'Planet' and parents[0].Scan.Rings then return true, 'Inclined Moon', '' end end ::End::

::Criteria:: if scan.Landable and scan.OrbitalInclination < -5 and scan.OrbitalPeriod < 2600000 and parents then if parents[0].Scan and parents[0].ParentType == 'Planet' and parents[0].Scan.Rings then return true, 'Inclined Moon', '' end end ::End::

Xjph commented 5 months ago

Planets very near their parent star should already trigger the close relative orbit criteria for any reasonably large star. 20ls is a bit far for my taste of what I'd consider "close".

Inclined moons is a good one though and I've seen a lot of people adding it as a custom criteria. It may well be time to promote it to default. I'll see if I can squeeze it in.