Xjph / ObservatoryCore

Elite Observatory: Extensible tool for processing Elite Dangerous journals
https://observatory.xjph.net/
MIT License
86 stars 16 forks source link

feat(core,herald): Unify volume settings; make overrides dynamic #159

Closed fredjk-gh closed 4 months ago

fredjk-gh commented 4 months ago

Previously, there was a large volume of volume controls -- which didn't all work:

So now we have 1 volume control to rule them all, now located in core settings, not native voice settings (so always visible/available), which controls ALL audio levels (plugin-provided and native audio). Thus, the Volume setting in Herald is removed.

Of course, to test control of native voice volume, I needed to disable Herald -- which previously required deleting the dll from the plugins folder and restarting the app. That was too much work and doesn't make sense now with the checkboxes in the plugin list to enable/disable plugins. So now, if you toggle Herald's checkbox, it will dynamically enable/disable native voice function AND hide/show the settings. No deleting of dlls. No restarting the app!

One last tweak: I moved the plugin settings and plugins folder buttons below the plugin list to be on the left side rather than the right side to locate them closer to where you'd select a plugin (useful for wide/landscape windows).

image