search

Xkonti / govec

Go library providing 2D and 3D vector operations
MIT License
6 stars 7 forks source link

Implement `RotateDeg` operation #23

Closed Xkonti closed 1 year ago

Xkonti commented 1 year ago

Rotates a vector by an angle specified in degrees.

Functions for integer vectors should return a float vector.

KarolosLykos commented 1 year ago

@Xkonti I would also like to work on this. Could you assign this to me?

KarolosLykos commented 1 year ago

I believe the implementation for 2D vectors is straightforward. However, for 3D vectors, I plan to introduce an additional argument in the 'rotateDeg' operation. This allows users to specify the rotation axis. Your input is valuable, so please feel free to share your thoughts!

KarolosLykos commented 1 year ago

@Xkonti Hello there! I hope you're doing well. I wanted to kindly ask if you could spare a moment to review my pull request (#50 ). I would greatly appreciate your feedback.

Xkonti commented 1 year ago

@KarolosLykos Looks good. I'm planning to focus on more advanced 3D vector math (rotations etc) after completing the 1.0. That will include concept like plane, axis, quaternion, but this simple approach here is fine for now.