Xlinka / NeosPlus

NeosVR Plugin Extra Logix nodes and features
https://discord.gg/9QAaMtXwke
Other
29 stars 18 forks source link

Add more nodes that return slot collections (and add my Neos path to csproj) #150

Closed Nytra closed 1 year ago

Nytra commented 1 year ago

Add GetAllParents and GetAllChildren nodes, GetChildrenWithName/Tag and GetParentsWithName/Tag. Also adds my Neos path to the .csproj.

Xlinka commented 1 year ago

has this been tested ?

Nytra commented 1 year ago

has this been tested ?

I tested them myself briefly and they all seemed to work.

Xlinka commented 1 year ago

hello nytra just coming back round to all this are you available sometime to show me these.

Xlinka commented 1 year ago

@Frozenreflex want to review this since the collection stuff is your brain child

Xlinka commented 1 year ago

just went through and tested them these seem to work on my system

Nytra commented 1 year ago

Linka said the nodes here should be outputting ReadOnlyCollections instead of Lists. If this is the case then probably the existing GetChildrenWithTag LogiX node (which was previously merged) should be updated as well.

Xlinka commented 1 year ago

It's something @Frozenreflex said and I'm just wondering if I misinterpreted what they said or if we must do this wait till they reply

Xlinka commented 1 year ago

oof conflict tag @Nytra soryyy

Nytra commented 1 year ago

Fixed conflict, also fixed category strings and a couple of bugs