XmYx / ainodes-installer

Installer for aiNodes, a desktop AI suite
GNU Lesser General Public License v2.1
4 stars 4 forks source link

Repetitive dubious ownership error issue. #1

Open AdvaitaSprite opened 1 year ago

AdvaitaSprite commented 1 year ago

Now, when it comes to individual folders needing to be added to the safe directory list, I know how you fix this very common error, of course (the classic "git config --global --add safe.directory [directory path]" command)... Usually you just need to run it once for a single directory and it's solved. However... The way this installer works makes this an incredibly frustrating obstacle (and I don't want to just disable this critical security feature across all directories-- it exists for a reason)...

Because the installer stops every time it reaches a file which needs to have the directory it's being installed into added to the safe.directory list, that means that you have to do it over. And over. And over... I don't even know whether to keep going, because it could be 10 more or it could be 100 or 1000 more-- there's no way to know except maybe digging through the code in the installer files, which is just not something that should be expected of users...

So it tries to install BLIP... Gets stopped due to dubious ownership-- so you have to open GitBash or whatever you're using, do the commands for the BLIP directory. Then close the installer window and start it up again... Only for it to reach the next file (say, MiDaS)... Then it gets stopped again and you have to put in the safe.directory command for the MiDaS directory... Then ESRGAN, then pytorch3d-lite, and so on, and so on, for every single new directory in the installation process... This really needs to be fixed because it's incredibly prohibitive. It would still be bad if you could at least run the installer once and have it tell you the error message saying you need to add safe.directory for every single installation directory and could at least copy/paste them all out of that window... But when you literally have to shut the installer, start it over, let it get to the next file, only to have to stop and do it over again (at least a dozen times, because that's where I've stopped and am considering giving up, but potentially many more)... It's just not a good user experience. Short of shutting down that whole security feature idk how others are getting around it. If there is a fix I can use let me know, but it seems like it should definitely be fixed in the coding so that you can just run the installer once (or at least the couple of times it takes to get pytorch and conda and everything set up & running) and be done with it.

Thanks. I am excited and curious to see what this new UI is like-- the features sound really cool... But it's been tough to get it up and running.

P.S. Just FYI, I did try updating Git to the newest version because I read on Substack that it should solve these errors once & for all, but I'm still getting them, so not sure what's the deal with that supposed fix.

XmYx commented 1 year ago

Hi!

Thank you! Yes, I did notice, when I was running it outside of my normally safe directories. I will look into it, how I can fix it and make it work, probably by declaring some of those deps elsewhere. For the while being, I'd encourage you to try cloning the main repo from https://github.com/XmYx/ainodes-pyside and run the clean install.bat on windows, just make sure you have conda installed. That method was maintained lately, and the gui installer is not yet caught up. We are actually also coming out just now with the actual node engine, you can test that at https://github.com/XmYx/ainodes-engine . Thank you for your patience!