XmacsLabs / lolly

lolly: A user-friendly C++ library
https://xmacslabs.github.io/lolly/
GNU General Public License v3.0
10 stars 6 forks source link

[12_12] re-impl load_string on tbox #151

Closed Charonxin closed 1 year ago

Charonxin commented 1 year ago

test wip

da-liii commented 1 year ago

Please add unit test for string_load, be careful of the size of the loaded string.

Charonxin commented 1 year ago

Testing will be done tomorrow, it can even read scip full.

Charonxin commented 1 year ago

为什么这边要做这样的判断?

https://github.com/XmacsLabs/lolly/pull/151/files#diff-e0fb6c0a8d64625b7f1ab13fb97ed4f5dba4843245722c27ddfee7f2b490a878R321-R325

我觉得是concretize的问题

[DEBUG] can access file
[DEBUG] removed file
[DEBUG] can create file
[DEBUG] test s1: C:\users\charon\Temp\.lolly\load_string_1.txt
[DEBUG] test s:
[DEBUG] load_string C:\users\charon\Temp\.lolly\load_string_1.txt
[DEBUG] error free
[DEBUG] name: \\C:\users\charon\Temp\.lolly\load_string_1.txt\
[DEBUG] path: C:\users\charon\Temp\.lolly\load_string_1.txt

concretize函数在mingw和windows平台解析的字符串为什么前后要带\?

Charonxin commented 1 year ago

concretize函数我认为是有点问题的。。

Charonxin commented 1 year ago

@jingkaimori @darcy-shen

da-liii commented 1 year ago

可以不用concretize

Charonxin commented 1 year ago

可以不用concretize

对 我是想问这个concretize是否是有问题的??加\是特性还是(bug?)

Charonxin commented 1 year ago

mogan里面用不了

;unbound variable nullary-indent in (indent-set-arity nullary-indent 0)
;    (indent-set-arity nullary-indent 0)
;    /home/charon/mogan/build/packages/app.mogan/share/Xmacs/progs/utils/misc/tm-keywords.scm, line 34, position: 1214
; ("/home/charon/mogan/build/packages/app.m...
; ("/home/charon/mogan/build/packages/app.m...
; ("/home/charon/mogan/build/packages/app.m...

free(): invalid pointer
da-liii commented 1 year ago

mogan里面用不了

那说明这个实现还有问题,我们需要知道为什么会有问题