Closed jingkaimori closed 7 months ago
Let me complete the macOS part?
Let me complete the macOS part?
yes, you can commit directly on this branch.
Failure of lint ci may be erroneous, such indentation cannot pass formatter installed on my computer
Failure of lint ci may be erroneous, such indentation cannot pass formatter installed on my computer
It seems to be a clang-format bug.
build and test ok on my macOS 14, what C++ standard are you using?
Which pr should I merge first to minimize the code changes (git conflicts)? This pr or https://github.com/XmacsLabs/lolly/pull/295?
Replacing the legacy string with lolly_string should be done in a project, for example project 21.
It should be done in several small pull requests.
Which pr should I merge first to minimize the code changes (git conflicts)?
what C++ standard are you using?
C++17, written in xmake.lua
It should be done in several small pull requests.
only split headers from basic.hpp can be move to another pull request
build and test ok on my macOS 14, what C++ standard are you using?
Here is the clues to fix ci on macOS https://github.com/llvm/llvm-project/issues/59374
LGTM, and you should split the pull request into smaller ones.
You can split basic.hpp
in 21_1
, and then re-implement as_string in 21_2
You can use cherry-pick and git squash to split this pull request.
Two part of this pr is merged, so close this one
Changes
basic.hpp
thustm_ostream.hpp
andstring.hpp
can include part of its contentstring(const char*)
constructor. Please useas_string
instead, except constructing from string literal.as_string
lolly_string
and test of blackboxPerformance
Before
string from int_16
string from int_32
string from int_64
string from double
After
string from int_16
string from int_32
string from int_64
string from double