Xmader / musescore-downloader

⚠️ This repo has moved to https://github.com/LibreScore/dl-librescore ⚠️ | Download sheet music (MSCZ, PDF, MusicXML, MIDI, MP3, download individual parts as PDF) from musescore.com for free, no login or Musescore Pro required | 免登录、免 Musescore Pro,免费下载 musescore.com 上的曲谱
https://github.com/LibreScore/dl-librescore
MIT License
2.7k stars 199 forks source link

Userscript Not Working in SmartCookieWeb Browser #137

Closed moriel5 closed 1 year ago

moriel5 commented 2 years ago

SmartCookieWeb is a popular lightweight browser for Android (it runs on the system WebView), and it features a userscript manager.

Unfortunately, your script does not appear to work with it (perhaps because this is a mobile device?), with none of the buttons appearing on the page, even if I set the user agent to desktop.

I do not use Discord, due to privacy not being respected there, so I cannot post the issue there (and what is the point of this GitHub repo, if not for issue reporting?).

sealsrock12 commented 2 years ago

The GitHub repository exists because it makes pull requests easy and it is the most well-known host for open-source code. We use issues for bug reports attached to PRs and other cases where a "civilized" discussion is useful, not for support questions where a chat is more convenient.

I haven't used SmartCookieWeb before, but does it follow all of the standards that userscript managers like Tampermonkey use?

moriel5 commented 2 years ago

Thanks for clarifying, I was confused whether the actual development was here or not. Sorry for coming out as being rude.

Regarding the userscript standards, I'll ask.

moriel5 commented 2 years ago

Sorry it took so long, the dev didn't have the chance to look at my issue until now (my issue was marked as stale 2 or 3 times, forcing me to bump it to prevent it from being automatically closed).

Here is the relevant excerpt from his answer: "...@match , @include , @run-at and @grant UserScript header attributes. @resource is supported in some circumstances. ..."

SmartCookieWeb is a WebView-based browser, which makes it hard to properly support userscripts, so if this isn't enough, I guess that there isn't much to do about it (a Chromium-based version is in the works, however, which may mitigate this).

PeterNjeim commented 2 years ago

Also of note: this repo is not updated anymore. Please use the new repo: https://github.com/LibreScore/dl-librescore.

moriel5 commented 2 years ago

@PeterNjeim Thanks, I'll open an issue there when I have the time.

Xmader commented 1 year ago

Reopened as https://github.com/LibreScore/dl-librescore/issues/13

(I can't transfer issue across organizations)