Musescore patched "Unauthorized use of Copyrighted Content"

Xmader / musescore-downloader

⚠️ This repo has moved to https://github.com/LibreScore/dl-librescore ⚠️ | Download sheet music (MSCZ, PDF, MusicXML, MIDI, MP3, download individual parts as PDF) from musescore.com for free, no login or Musescore Pro required | 免登录、免 Musescore Pro，免费下载 musescore.com 上的曲谱

https://github.com/LibreScore/dl-librescore

MIT License

2.71k stars 197 forks source link

Musescore patched "Unauthorized use of Copyrighted Content" #48

Open dayoshiguy opened 3 years ago

dayoshiguy commented 3 years ago

It says I have a banned plugin and that they very angery lol

Xoncia commented 3 years ago

Just comment your keybase username Ill make a discord

Xoncia commented 3 years ago

https://discord.gg/MmYkkkHzfE first 10 can join @Xmader if you can please join When you have time of course 🙂

North-West-Wind commented 3 years ago

Hey @Xmader I think they patched it again. However, it seems that they only removed the GUI when extension is detected (By removed I mean it turns into the "Unauthorized use of Copyrighted Content" thing).

The detection takes a few seconds and I was quick enough to click the "Download MSCZ" button, and although the preview is gone, the script can still run in the background.

Andrew-J-Larson commented 3 years ago

I found something out, if you just take the code and run it later after the website is finished loading the script will run fine.

I suggest maybe having the script run after a timeout of maybe 5 to 10 seconds... I'll do some more testing and publish a merge pull of my suggested changes.

Andrew-J-Larson commented 3 years ago

See my pull https://github.com/Xmader/musescore-downloader/pull/50... the script works again, but must wait 8 seconds at the least so far for it to work again without tripping Musescore.

marcan commented 3 years ago

If you use such a script and it violates the website T&C's, they could hypothetically sue you. They could also hypothetically sue you for copyright infringement if they have agreements with publishers. They could sue you for any made up reason whatsoever, because anyone can sue anyone else (especially in the US). Whether they would win any such lawsuits is something I'm not qualified to give an opinion on.

They cannot, however, send the police to your door. At least not in most jurisdictions.

Practically speaking, it's blatantly obvious that the warning is an amateurish attempt at scaring people, and that no actual competent lawyers are running this operation at MuseScore.

Andrew-J-Larson commented 3 years ago

They especially can't do anything against people that aren't redistributing the stuff they download through this extension.

Andrew-J-Larson commented 3 years ago

In any case though, @Xmader not sure if this will help at all, as I'm not the best at reverse engineering... but I believe I found the part in Musescore's source code that detects when your downloader is loaded... note the zip file only contains the one JS file, but it 'talks' with other files when doing the detection. I did however highlight and include a note of where such assumed detection is taking place.

https://anonfiles.com/v3369fn9p5/Musescore_s_Downloader_Detection_in_JS_source_zip

Andrew-J-Larson commented 3 years ago

As for the other files you might want to look at are: ms~runtime..........js, ms.........js, system...........js, and maybe the vendor........js

(......... imply the strings that always change)

Andrew-J-Larson commented 3 years ago

Wait nevermind, I see you already know that when taking a look at https://github.com/Xmader/musescore-downloader/blob/master/src/btn.ts