search

Xman1109 / Atomic_Overhaul

https://mods.factorio.com/mod/Atomic_Overhaul/downloads
Other
7 stars 5 forks source link

[Game Crash] #51

Closed SGZ-Creations closed 3 months ago

SGZ-Creations commented 6 months ago

Mod Crashed Game

Your factorio-current.log / error message screenshot

image

A list of Mods you are playing with (mod-list.json / written out list)

mod-list.json

Your Idea why it crashed?

icon size.
SGZ-Creations commented 6 months ago

image Still crashing

Sorry for the re-ping

SGZ-Creations commented 4 months ago

Any chance this is being fixed?

Xman1109 commented 3 months ago

I am currently in an awkward position, I should have time next week, sorry it's taking so long

Xman1109 commented 3 months ago

Should be fixed now, but it could be that some radioactive elements have a weird glow (too big or too small), but I will need to look at that later.

SGZ-Creations commented 3 months ago

Update on this crash after the attempted fix image

SGZ-Creations commented 3 months ago

Suggestion by Cookie Nomster On Omni Discord

it's obvious it doesn't work properly with all kinds of icons (i mean atomic overhaul). they probly don't check if icon_size is set ... while icon_size is mandatory, it can be set outside, and it defaults to 32, so you don't need to set icon_size in your mod, and game will expect 32x32px icon icon_size can be set anywhere in code, look at examples here https://lua-api.factorio.com/latest/types/IconData.html eg. you can set icon_size either at prototype level, icon level, or even icon layer level

Xman1109 commented 3 months ago

I have tried the thing you suggested, I hope it works this time, otherwise I don't know what I could do different, so maybe you need to send me a savegame will all your mods, so that I can sync them. Reading through +800 lines of mod-list.txt is a bit much xD

Xman1109 commented 3 months ago

before I upload a version that breaks everything again, this update is only on GitHub while you test it.

SGZ-Creations commented 3 months ago

i can test if u can compile it like before uploading

Xman1109 commented 3 months ago

Atomic_Overhaul_1.3.25.zip

Xman1109 commented 3 months ago

Btw, factorio mods don't need to be compiled, you can just download the directory and put it in your mods directory

SGZ-Creations commented 3 months ago

I know that but i have times where i can push file to my git and the update can crash so i prefer folder of sort to use that don't have basic crashes due to typos.

SGZ-Creations commented 3 months ago

So i have good new it works all well again. image

Thanks a lot for the work and effort on fixing this issue

SGZ-Creations commented 3 months ago

it works as intended on Bob's and Angel's mod just to give you the confirmation on it too.

Xman1109 commented 3 months ago

Ok, then I'll thank you for reporting the issue