search

Xmetalfanx / Complete_Homepage

Git Repo for my website
1 stars 1 forks source link

Hamburger Menu w/bootstrap 5 alpha #71

Closed Xmetalfanx closed 3 years ago

Xmetalfanx commented 4 years ago

the border shows but the "hamburger" (3 lines inside) are not showing on the top menus or lower resolutions

Xmetalfanx commented 4 years ago

https://github.com/Xmetalfanx/website/commit/89b9ab6aa8e57d9bcddd304eeb29cd7073ab1398

the alignment of the "burgers" is not correct when on Boostrap 4.x but as the message of this commit says, it is aligned in my tests of Boostrap 5

Xmetalfanx commented 3 years ago

to close this issue make sure the hamburger menu is working when bootstrap is blocked ... if it works then (since i may be moving to remove css frameworks to cut down on third party browser requests, and this is not important anymore)

Xmetalfanx commented 3 years ago

Ok, so after I 100% removed the calls for Boostrap and testing both sides of the site, everything still works .. so I am closing this issue as I am moving to remove all BS calls eventually (again nothing against Boostrap or other frameworks... I just want to simplify/optimize things)

Note: HERE i am NOT removing BS just yet .. I want to make sure style (CSS) wise everything seems to work... I had just removed it for testing, so I could close this issue