search

Xmetalfanx / Complete_Homepage

Git Repo for my website
1 stars 1 forks source link

Elminate CSS there for no reason #98

Closed Xmetalfanx closed 3 years ago

Xmetalfanx commented 3 years ago

I noticed in some elements i have say "display: flex" and "display: grid" ... card__header comes to mind ... in this specific case Flex is default and there shouldn't be any reason to change that that I can see

Xmetalfanx commented 3 years ago

looking in the mainsection.scss sass file ... that is where i had "card__header" set to grid .... I am NOT sure why I did that .... now i have it set to what I need in CSS so the testing just basically means go page by page (for the most part) and see if things in the main section seem broken .... already i can say things seem to be working

Xmetalfanx commented 3 years ago

i am issue I am finding is that in some areas I have (a left hand column and/or a right hand column) 

<div class="card_header"....
    <div ..... 
         [left hand item code here>
    </div>

    <div ..... 
         [right hand item code here>
    </div>
</div> <!-- close of card__header -->

in other areas I have 

<div class="card_header"....
         [left hand item code here>

         [right hand item code here>

</div> <!-- close of card__header -->

when i have more than one item in either section (say an Icon + a program name) ... NOT having that extra div throws things off layout wise

Xmetalfanx commented 3 years ago

https://github.com/Xmetalfanx/website/commit/a39765f5e04f1bf76218f5a123b82a260290a3db addresses this in part

https://github.com/Xmetalfanx/website/commit/625229c6884c998cf5d93d2cce4e1d41f7c5fc42 Does as well

I went through both sides of the site and randomly sections of what pages use card__header and everything APPEARS to work