search

Xmetalfanx / linuxSetup

Xmetal's Linux Scripts
GNU General Public License v3.0
2 stars 2 forks source link

Code check - Deadbeef install on OpenSUSE Leap and Fedora #234

Closed Xmetalfanx closed 1 year ago

Xmetalfanx commented 1 year ago

when redoing things for dynamic .desktop file creatiion ... I think something is missing in my Deadbeef code ... I will mark this as a bug for now but this is a potentional bug. I think both/either use RPMFusion or Packman respectively but after the check for those repos ... i dont see an "install " step

Xmetalfanx commented 1 year ago

https://github.com/Xmetalfanx/linuxSetup/commit/27fcf3009773c232e8a4a2f6f150b8d648f21c98 improved the code (this may not have been a "bug" per-say) ... I still want to do some testing before closing this

Xmetalfanx commented 1 year ago

atm openSUSE Leap's install is failing due to it thinking (no matter what is selected) "I dont want to install the third party (aka packman) repo" when that is needed.

underlying issue may be code inconsistancies between "thirdPartyRepoExists" being "true" or "yes"

Xmetalfanx commented 1 year ago

in my latest dev branch commit I saw a pass on OpenSUSE leep once but I want to retest that.

Fedora VM = Pass

Xmetalfanx commented 1 year ago

https://github.com/Xmetalfanx/linuxSetup/commit/a8c09061c0f9a55beb047d3c2380193c246abefb fixes this and tests on both work.

Since I redid the code that runs if a third party repo is needed (the user is asked and if the repo is enabled or the user says "yes enable this" if its not already) ... i want to check that code before i do another release