Xmetalfanx / linuxSetup

Xmetal's Linux Scripts
GNU General Public License v3.0
2 stars 2 forks source link

Doublecheck third party repo needed install code #237

Closed Xmetalfanx closed 1 year ago

Xmetalfanx commented 1 year ago

https://github.com/Xmetalfanx/linuxSetup/issues/234 fixed an issue but MAY have introduced another. Check if other things broke before doing a release even though i have syned with master already

Xmetalfanx commented 1 year ago

I need to check a few things .... say with Deadbeef ... "If the repo is enabled, and all that questioning to the user about needing a third party repo is skipped ... does it drop passed all of that code like it should and install if the repo is already there?"

Also what other programs notify the user about needing a third party repo that may have broken?

Xmetalfanx commented 1 year ago

also consider making a feature branch to test why this new fix only has that "third party needed code" accepting a single app name ... i had it where it could accept a few if needed ... i maybe should see why that doesn't work

Xmetalfanx commented 1 year ago

https://github.com/Xmetalfanx/linuxSetup/commit/6987fb092e11185e2fcfab2f5c00d02e61547536 addresses this and fedora and leap tests work