search

XombieOnline / xombie

GNU Affero General Public License v3.0
57 stars 9 forks source link

Control init packet may have authorization data vector length != 1 #4

Open mborgerson opened 2 years ago

mborgerson commented 2 years ago

When attempting Xbox Live connection test from Xbox Dashboard settings menu, such a packet may be sent. In this case, process_control_init will error out here causing the test to fail:

https://github.com/XombieOnline/xombie/blob/7a1ef08045271437efc5938c996cb0c209a31408/services/sg/src/init.rs#L133

My workaround to just get the test to pass is here: https://github.com/mborgerson/xombie/blob/hacks/services/sg/src/init.rs#L129

Apparently only AD_TYPE_SERVICE_ADDRESSES are handled now, but this needs to be updated to also handle AD_TYPE_USERS.

GXTX commented 2 years ago

What is your live dash version? You can find this by pressing Y after failing/passing the test. Testing on 5971 I see the same thing and required your patch to pass.

mborgerson commented 2 years ago

What is your live dash version? You can find this by pressing Y after failing/passing the test. Testing on 5971 I see the same thing and required your patch to pass.

5849