search

Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

Fixed Issue #109 #111

Closed iiEpic closed 4 years ago

iiEpic commented 4 years ago

Verified in comments for issue 109

iiEpic commented 4 years ago

Hey @Xonshiz , On line 92 of browser_instance.py the same b' needs to be added. I forgot to hit that one up on my commit. I saw it tonight and wanted to make sure you knew.

Line 92 should now read: if b'href=\"/logout\"' in html_source:

Xonshiz commented 4 years ago

Thanks for the update. I'll add it on my side and release a binary later tonight.

Thedarklife74 commented 4 years ago

Thanks for the update. I'll add it on my side and release a binary later tonight.

Nice have you updated the binary ?

Xonshiz commented 4 years ago

Not yet.

Thank You, Dhruv Kanojia (Github https://github.com/Xonshiz| Website https://itsxonshiz.in | Twitter https://twitter.com/Xonshiz | LinkedIn https://in.linkedin.com/in/dhruvkanojia | Google+ https://plus.google.com/+DhruvKanojia)

On Mon, Jan 6, 2020 at 7:22 PM Thedarklife74 notifications@github.com wrote:

Thanks for the update. I'll add it on my side and release a binary later tonight.

Nice have you updated the binary ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Xonshiz/anime-dl/pull/111?email_source=notifications&email_token=ADFAR55SLKDK6ATNYYT3DXTQ4PDOFA5CNFSM4KCY4QTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHH2WA#issuecomment-571374936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFAR5373G3US2LCUUM3LRLQ4PDOFANCNFSM4KCY4QTA .

iiEpic commented 4 years ago

test_distro.zip

@Thedarklife74 Try out this binary with the newest update from Xonshiz. I pulled his newest update into mine and remade the exe. Let me know if it works.

EDIT: That zip file contains ONLY the exe file. Nothing more.

Thedarklife74 commented 4 years ago

test_distro.zip

@Thedarklife74 Try out this binary with the newest update from Xonshiz. I pulled his newest update into mine and remade the exe. Let me know if it works.

EDIT: That zip file contains ONLY the exe file. Nothing more.

It seems archive is corrupted

iiEpic commented 4 years ago

anime-dl.zip @Thedarklife74
My apologies. Try this one, the previous one I zipped using my Linux machine and sometimes I've noticed it corrupts stuff.. my bad haha

Also for reference, these two screenshots show it working with the current build https://gyazo.com/360c86c26dba9c0080ec191d5444cac9 https://gyazo.com/2c8a3de0d5891cc64ae63ebfb7edeae4

Thedarklife74 commented 4 years ago

anime-dl.zip @Thedarklife74 My apologies. Try this one, the previous one I zipped using my Linux machine and sometimes I've noticed it corrupts stuff.. my bad haha

Also for reference, these two screenshots show it working with the current build https://gyazo.com/360c86c26dba9c0080ec191d5444cac9 https://gyazo.com/2c8a3de0d5891cc64ae63ebfb7edeae4

Work perfectly ! Big thanks :)

iiEpic commented 4 years ago

Perfect! I'm glad it worked out man. @Xonshiz If you want a binary to add the one above is from the newest source code after you made your #111 commit boss man.

Thedarklife74 commented 4 years ago

@EpicUnknown here we go again. I change nothing on my computer :

Trying to login... Let me check again... Unable to Log you in. Check credentials again. Failed Login!!! Traceback (most recent call last): File "anime_dl__main.py", line 22, in class Main(): File "anime_dl__main__.py", line 82, in Main logger=logger, episode_range=args.range, output=args.output) File "anime_dl\Anime_dl.py", line 30, in init__ skipper=skipper, logger=logger, episode_range=episode_range, output=output) File "anime_dl\sites\crunchyroll.py", line 49, in init NameError: name 'exit' is not defined [1548] Failed to execute script main

iiEpic commented 4 years ago

What was the command you tried using?

Thedarklife74 commented 4 years ago

What was the command you tried using?

same as always :

anime-dl.exe -i "link" -u "user" -p "pass" -r "720" -v

Before yesterday it work perfectly and yesterday it don't work anymore. My account work on the webiste and he's premium

iiEpic commented 4 years ago

Not sure what's going on but let me see the verbose info. Remember to remove any info that is on your account.

Thedarklife74 commented 4 years ago

Not sure what's going on but let me see the verbose info. Remember to remove any info that is on your account.

DEBUG: You have successfully set the Debugging On. DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/fr/somali-and-the-forest-spirit/episode-3-the-sea-at-the-bottom-of-the-cave-792595'], language='Japanese', output=None, password=[''], range='All', resolution=['720'], skip=False, username=[''], verbose=True, version=False) DEBUG: Operating System : Windows - 10 - 10.0.18362 DEBUG: Python Version : 3.7.4 (32bit) DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: https://www.crunchyroll.com:443 "POST /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET / HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr HTTP/1.1" 200 None

iiEpic commented 4 years ago

Not sure what's going on but let me see the verbose info. Remember to remove any info that is on your account.

DEBUG: You have successfully set the Debugging On. DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/fr/somali-and-the-forest-spirit/episode-3-the-sea-at-the-bottom-of-the-cave-792595'], language='Japanese', output=None, password=[''], range='All', resolution=['720'], skip=False, username=[''], verbose=True, version=False) DEBUG: Operating System : Windows - 10 - 10.0.18362 DEBUG: Python Version : 3.7.4 (32bit) DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: https://www.crunchyroll.com:443 "POST /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET / HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr HTTP/1.1" 200 None

That so strange. I just ran my anime-dl.exe with the same file you're trying to download and didn't have any problems.. I wonder what's happened in your case. Is it just that episode or all?

Thedarklife74 commented 4 years ago

Not sure what's going on but let me see the verbose info. Remember to remove any info that is on your account.

DEBUG: You have successfully set the Debugging On. DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/fr/somali-and-the-forest-spirit/episode-3-the-sea-at-the-bottom-of-the-cave-792595'], language='Japanese', output=None, password=[''], range='All', resolution=['720'], skip=False, username=[''], verbose=True, version=False) DEBUG: Operating System : Windows - 10 - 10.0.18362 DEBUG: Python Version : 3.7.4 (32bit) DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: https://www.crunchyroll.com:443 "POST /login HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr/login HTTP/1.1" 200 None DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443 DEBUG: https://www.crunchyroll.com:443 "GET / HTTP/1.1" 302 None DEBUG: https://www.crunchyroll.com:443 "GET /fr HTTP/1.1" 200 None

That so strange. I just ran my anime-dl.exe with the same file you're trying to download and didn't have any problems.. I wonder what's happened in your case. Is it just that episode or all?

All,

Anyway for unknow reason it work today ....

Thedarklife74 commented 4 years ago

@EpicUnknown doyou trust me if i said yesterday script working and today no ? I think I'm going to turn crazy

iiEpic commented 4 years ago

@Thedarklife74 That's quite interesting.. I'm not understanding how you're having these problems honestly.

The best advice I can give it to delete your 'anime-dl' exe and redownload the one I gave you the other day. Idk what else to suggest at this point.