search

Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

Feature suggestion - set 'language' prop. for subs and allow selecting default track #26

Closed flagg19 closed 6 years ago

flagg19 commented 6 years ago

Subject:

For crunchyroll (don't know about the others), subtitle tracks aren't assigned a language. It would be cool to have the language set, so that all players that allow setting things like: "use lang regardless of what default track is in the file" could work. Also, I've seen that the default subtitle language is hard-coded as English, can it be turned into a new script parameter?

Long Explanation:

  1. Note that I only use crunchyroll, I don't know how thing works for other sites, nor if what I'm proposing is applicable to them.
  2. Also note that here I'm only talking about subtitle tracks, but it might be interesting to also consider audio/video tracks.

I can barely read python but for setting the language on crunchyroll subtitles it should be enough to add --language "N:lang" on all the lines regarding subtitles: https://github.com/Xonshiz/anime-dl/blob/7ba09e53bd8285ebbf9714dc5b65125d22749f4a/anime_dl/sites/crunchyroll.py#L234-L282

Xonshiz commented 6 years ago

A friend of mine asked me to do this a few months back. It's a nice feature to have. I'll look into it and hopefully be done with it by the end of this month :)

Xonshiz commented 6 years ago

Fixed the subtitle naming thing. Please open a separate issue for making the default subs. I'll be working on it side by side, will take some time.