search

Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

Arabic Subtitles Cause Script to Fail/Incorrectly Handled #39

Closed leptoid closed 6 years ago

leptoid commented 6 years ago

When an episode of a show with subtitle arME.ass is downloaded, subs and video mux. Script errors and continues on with the next function of the script which is deleting all temp files (note - nothing is moved to output). Not all shows have these which is why error seems intermittent between shows. Here are some that do:

Boruto
The Ancient Magus
Darling In The Franxx

Delete the arME.ass subtitle file before scripts attempt to multiplex subtitles with video allows everything to mux correctly, due to the incorrectly handled subs no longer being a factor.

Xonshiz commented 6 years ago

Thanks for creating the new issue. Noted.

Xonshiz commented 6 years ago

Shouldn't cause more problems now. Updated windows binary released, check on your end please.

leptoid commented 6 years ago

Yep, it is good now.

Xonshiz commented 6 years ago

Thanks for the confirmation :)