Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

add support for --language in mkvmerge #50

Closed Abu3safeer closed 6 years ago

Abu3safeer commented 6 years ago

P.S: I am not python developer, but I tried my best to not ruin the code. video players now could recognize the language, it should select the right language according to user preferences.

Abu3safeer commented 6 years ago

Thank you for the merge, could you please update windows binary? I want to test it to see if it works properly.

Xonshiz commented 6 years ago

Will release later today after I fix a few things.

Xonshiz commented 6 years ago

and thanks for the PR :)

Abu3safeer commented 6 years ago

Okey, waiting for it.

Abu3safeer commented 6 years ago

PR? Sorry I don't know what it means.

Xonshiz commented 6 years ago

Pull Request

Abu3safeer commented 6 years ago

Oh, didn't notice that, I googled that and found "Public relations" 😆 No problems, you are welcome, I wish I could do more.

Abu3safeer commented 6 years ago

Hello @Xonshiz , Any chance to get this update this weekend? Thank you.