search

Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

Currently not grabbing 1080p versions of shows and not showing Resolution correctly #86

Open axipher opened 5 years ago

axipher commented 5 years ago

See below attachment, two different shows both giving the same result of "DEBUG: video_resolution : x"

The actual downloaded file is also 720p instead of 1080p as my settings indicate.

error.log.txt

aspablo commented 5 years ago

@Nicnl Tried the linked exe. Still same error image Error Log.log

Edit:

image I can stream it fine though

Abu3safeer commented 5 years ago

Whoh, what is happening here! image

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=953424,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=500945,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=387101,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
Nicnl commented 5 years ago

Wait guys, there's something wrong
Maybe I've linked the wrong build, you sould have more logs than just "could not find"

Abu3safeer commented 5 years ago

The funny thing that I add /ar/ language to the link and now it works image

aspablo commented 5 years ago

How are you guys extracting the resolutions info from the m3u8 links?

aspablo commented 5 years ago

@Abu3safeer lemme check

aspablo commented 5 years ago

ohho ho yes.. it worked! image But didn't you already fix the region issue since it contained extra '/'? @Nicnl

Nicnl commented 5 years ago

Holy cow, I've linked the wrong exe

Abu3safeer commented 5 years ago

Since I browse crunchyroll using Arabic layout, all my links contain /ar/, so I didn't recognize this issue at first, but later I recognize it. image

Abu3safeer commented 5 years ago

@Nicnl No problems, just link the correct one, and if you could remove the old one so if anyone tried to download the old one it will redirect him to the new one.

aspablo commented 5 years ago

Oh thanks @Abu3safeer and @Nicnl
Btw, now I am able to download shippuden as well. Just had to add the /ar/ or /fr/ to the url.

Nicnl commented 5 years ago

Ok, this time I hope it'll work...
Very sorry for the inconvenience guys...

aspablo commented 5 years ago

@Nicnl can't actually talk against you. Cuz you are making this stuff workable. Thanks man.

Abu3safeer commented 5 years ago

@Nicnl Actually I am the one who should be thankful for you, you are keeping this project alive, I really wish that I know python to help you.

This application could be more powerful that what it is.

I have even created a GUI for it using C# here: https://github.com/Abu3safeer/anime-dl-gui

aspablo commented 5 years ago

@Nicnl Thanks. The new exe works. Didn't need to add the fr/ar in url either. Thanks and good luck to you.

Abu3safeer commented 5 years ago

It is working like a charm now, even without language written. I wish @Xonshiz could respond and update this app with your patches.

Nicnl commented 5 years ago

THERE WE GO

Please note that there's still an ongoing issue I have to fix

It turns out that axipher noticed that some animes have very uncommon resolutions
For instance, Fairy Tail episode 1 is not 1920x1080..... it's 1920x1072, and it breaks everything

Downloading Fairy Tail - 02 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1072p, 240p, 360p, 480p, 720p]

And right now adding -r 1072p won't work, I need to do a few changes here and there for it to work
I'll try to fix it as soon as I have a bit of time in front of me

Abu3safeer commented 5 years ago

You might do groups: 1080p = 1080p - 721p 720p = 720p - 481p 480p = 480 - 361p 360p = 360p - 0p

So the application will get all resolutions, and put them in groups, so even if the resolution is not the exact 1080p it should consider anything above 720p is 1080p.

axipher commented 5 years ago

We all appreciate the offline builds @Nicnl

Hopefully you can easily update a pull request on this main one once @Xonshiz has some time.

Xonshiz commented 5 years ago

This might be an issue because currently, to anime-dl isn't authenticating properly. So, the token/cookies anime-dl gets aren't authorized for HD and FHD streams. I'll take a look at this, as I am re-building anime-dl.

axipher commented 5 years ago

Thanks @Xonshiz if you need testing, let me know and I'm glad to help test anything.

Xonshiz commented 5 years ago

Sure, thanks :). Will hopefully post something in 6 hours from now.

Nicnl commented 5 years ago

@Xonshiz
Out of curiosity
By rebuilding, do you mean you're rewriting everything from scratch?

axipher commented 4 years ago

Still having issues on some older shows with odd resolutions, this time "Full Metal Panic" (https://www.crunchyroll.com/full-metal-panic) which has 1440x1080 as its 1080p resolution.

.\anime-dl.exe -v -i https://www.crunchyroll.com/full-metal-panic -u $username -p $password -r 1080
Trying to login...
Logged in successfully...
Total Episodes to download : 24
Downloading Full Metal Panic - 01 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------

Downloading Full Metal Panic - 02 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------

Downloading Full Metal Panic - 03 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------
#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1816763,RESOLUTION=960x720,FRAME-RATE=23.974,CODECS="avc1.64001f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=3691028,RESOLUTION=1440x1080,FRAME-RATE=23.974,CODECS="avc1.640028,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=773164,RESOLUTION=640x480,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=482427,RESOLUTION=480x360,FRAME-RATE=23.974,CODECS="avc1.4d4015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=345414,RESOLUTION=320x240,FRAME-RATE=23.974,CODECS="avc1.42c00d,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx

And this is from "Gunbuster 2" (https://www.crunchyroll.com/gunbuster-2)

When I run the command with no resolution called out, it just fails, I need to add "-r 480p" for it to correctly grab the 480p videos

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1149128,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=613615,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=440351,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/
Zebraslive commented 3 years ago

https://github.com/Zebraslive/Mass-Anime-Downloader