search

Xonshiz / anime-dl

Anime-dl is a command-line program to download anime from CrunchyRoll and Funimation.
MIT License
229 stars 37 forks source link

Could not find the requested resolution [crunchyroll.py - Line 278] #91

Closed Abu3safeer closed 1 year ago

Abu3safeer commented 5 years ago

Looks like something changed in the m3u8 file.

image

https://github.com/Xonshiz/anime-dl/blob/master/anime_dl/sites/crunchyroll.py#L278

axipher commented 5 years ago

@Nicnl have you had a chance to clean up your fix for this issue to submit it on here? this may be the same issue that you helped me solve with modified version you compiled locally on your own computer.

Abu3safeer commented 5 years ago

This issue only appeared with me yesterday, so I really don't know what happened exactly, I checked error-log and everything seems fine.

I think developers of Python might notice something I don't see.

axipher commented 5 years ago

I'm trying that show now, episode 1 of the English dub is downloading fine, I'll see what it does when it gets to episode 12.

Just so that I'm trying this on the same episode as you, is that episode 12 form one of the Dubs, or the main show?

Abu3safeer commented 5 years ago

https://www.crunchyroll.com/rokka-braves-of-the-six-flowers-

Abu3safeer commented 5 years ago

image It download the subtitle and stop on video.

axipher commented 5 years ago

Maybe the show has different options in different regions. I get all these options when I go to that show. It looks like your issue is on the main show itself and not the English Dub. Once I finish downloading the English Dub, I'll try the regular show.

Rokka -Braves of the Six Flowers-
Rokka -Braves of the Six Flowers- (Spanish Dub)
Rokka -Braves of the Six Flowers- (German Dub)
Rokka -Braves of the Six Flowers- (French Dub)
Rokka -Braves of the Six Flowers- (Portuguese Dub)
Rokka -Braves of the Six Flowers- (English Dub)
Abu3safeer commented 5 years ago

I don't watch dub, only Japanese audio with Arabic subtitle, but video is not downloaded.

axipher commented 5 years ago

So I was able to download all 12 episode of both the English Dub and the Japanese.

Nicnl had made some fixes to his offline copy and was waiting to see if they worked and when he had time to put them up on here.

Shoot me an email to the email in my Bio on here if you need a copy of one of the episodes in the mean time.

Abu3safeer commented 5 years ago

Actually I don't need that anime in specific, I just want to fix the issue.

Nicnl commented 5 years ago

Hey @Abu3safeer

I wrote a few fixes a week ago
You can access the source code here: https://github.com/Nicnl/anime-dl/commits/master

I initially sent Facebook messages to @Xonshiz asking him if he could add me as an official contributor so that I could push bug fixes without bothering him

But I don't have any responses yet, so...
In the meantime, here is a compiled version, it would be great if you could tell me if it fixes your issue

Abu3safeer commented 5 years ago

image

It still skips the video: image

Abu3safeer commented 5 years ago

Looks like the issue is only with Rokka anime. image

Abu3safeer commented 5 years ago

After some tests I recognized that this issue appeares with "English" links, when there is no language in the url: https://www.crunchyroll.com/the-rising-of-the-shield-hero/episode-11-catastrophe-returns-781158 but if there is a language in the url it would work normally. https://www.crunchyroll.com/ar/the-rising-of-the-shield-hero/episode-11-catastrophe-returns-781158

if I deduct the language, it will return something like "type of non-object".

axipher commented 5 years ago

@Abu3safeer That is the same thing I already identified in issue #86

Did you try the new version of the EXE provided by @Nicnl? It works for the English links fine.

Abu3safeer commented 5 years ago

Yes, he has linked his new exe above your comment, I am doing it with it.