search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
558 stars 69 forks source link

Official cfscrape not updated #225

Closed Lofter1 closed 5 years ago

Lofter1 commented 5 years ago

Seems like the official cfscrape is not getting an update for the new cloudflare check any time soon, might consider (temporarily) using a working fork of it?

hallwayorchard commented 5 years ago

I was able to work around this using Zunjae's branch here

Lofter1 commented 5 years ago

While it is a workaround, I wouldn't like this approach as a user because of reasons users have stated in that Issue

HSeavers commented 5 years ago

I've changed it to cloudscraper, now it's working again. here is my pull-request https://github.com/Xonshiz/comic-dl/pull/229

Lofter1 commented 5 years ago

Lets hope Xonshiz didn't decide to let comic-dl die, too, in favour of his newer project.

Dissentrix commented 5 years ago

I'm not sure how to use the workaround for cfscrape, talked about above - it seems that project is dead in the water, and the comic-dl binary doesn't seem to work right now. I hope new instructions/a new way of bypassing cloudflare are going to be posted at some point.

Also, shouldn't comic-dl's error log redirect you to this tool's issues page? As you can see here I opened an issue on the cfscrape page, which is obviously not the correct place, as I'm very new to this whole thing.

Lofter1 commented 5 years ago

Also, shouldn't comic-dl's error log redirect you to this tool's issues page? As you can see here I opened an issue on the cfscrape page, which is obviously not the correct place, as I'm very new to this whole thing.

No, the error is coming from cfscrape, not comic-dl, so cfscrape is directing you to it's own repository.

Let's hope xonshiz is updating the repository with uaarrgghh's pull-request soon, cause the workaround isn't the best way to solve the issue either. The new pull-request is the best way to fix the problem for now.

Lofter1 commented 5 years ago

Ah never mind, i just saw Anorov updated cf-scrape now. We just need to update it, too. I think the issue is closed with this.