search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
546 stars 68 forks source link

please support webtoon bestChallenge and challenge #236

Closed gfhghfghfh closed 2 years ago

gfhghfghfh commented 5 years ago

https://comic.naver.com/genre/bestChallenge.nhn https://comic.naver.com/genre/challenge.nhn

Xonshiz commented 2 years ago

Naver is already supported. You should be able to pass the link of the comic to the tool and it'll download all the images in it.

gfhghfghfh commented 2 years ago

@Xonshiz

I know https://comic.naver.com/webtoon/weekday is already supported, but bestChallenge and challenge is not supported.

Can you click on the url I gave you to see?

https://comic.naver.com/genre/bestChallenge.nhn https://comic.naver.com/genre/challenge.nhn

ex: https://comic.naver.com/bestChallenge/list?titleId=791651 https://comic.naver.com/challenge/list?titleId=678448

Xonshiz commented 2 years ago

Just looked at the code. Well, this should've worked. But, looks like Naver has changed their URL scheme, that's the reason this isn't going through. Either they changed their URL scheme and the whole Naver download is broken or they introduced a new scheme as well.

Anyways, thanks for bringing this to notice. I'm re-opening this issue and will push a fix for this by tomorrow probably. Thanks for waiting such a long time and apologies :)

gfhghfghfh commented 2 years ago

thanks

"But, looks like Naver has changed their URL scheme" Regarding the issues mentioned above

I list some examples

not working comic_dl.exe -i https://comic.naver.com/bestChallenge/list.nhn?titleId=789786 comic_dl.exe -i https://comic.naver.com/bestChallenge/list?titleId=789786 comic_dl.exe -i https://comic.naver.com/webtoon/list?titleId=670152

working comic_dl.exe -i https://comic.naver.com/webtoon/list.nhn?titleId=670152

Xonshiz commented 2 years ago

Looks like new scheme got added as well. I picked these from comic.naver.com Homepage itself: https://comic.naver.com/webtoon/list?titleId=775318 https://comic.naver.com/webtoon/list?titleId=774044

These are the newly added URL schemes.

Anything with list.nhn or details.nhn will work. I'll add support for these new ones too. Then your challenge and bestChallenge ones should work too :)

Cool, I'll try to push the new changes by tomorrow (or in next few hours).

Xonshiz commented 2 years ago

I've added a fix for this issue. The latest binaries should be available as soon as GitHub Action completes and creates a new release. Please feel free to re-open if something doesn't work as expected.

Thanks