Closed pagbrl closed 3 years ago
Hi again ! Is there anything I can do to help merge this ? :)
Oops, I had totally overlooked this PR. Thanks for commenting. Let me review the changes and I'll merge :D
Hmm, about cloudscraper package, it's hard to say where to go about it. I might have to re-write certain things in this library to get it working properly. That package seems to be not being actively maintained anymore. Thanks for this PR though :)
Hi,
First of all thanks for the great job on this project !
I built the docker image from master branch and ended up getting an error.
I included a quick fix for this, commented out unused packages, and switched to
python:3.6.5-slim-stretch
base image to make the built image a bit lighter. I also removed this line :In the current state of the Dockerfile I don't think this line is useful. There is no multi-stage build as only one image is used and produced by the build for now.
I'm also interested in fixing this error (it appears when running comic_dl from within the built image) :
After digging a bit I suspect this has to do with the cloudscraper package, but couldn't find any indications on the project as how to fix this. I can implement a solution if anyone knows where I should look for this.
Let me know if I can help get this merged faster. :)