search

Xonshiz / comic-dl

Comic-dl is a command line tool to download manga and comics from various comic and manga sites. Supported sites : readcomiconline.to, mangafox.me, comic naver and many more.
https://github.com/Xonshiz/comic-dl
MIT License
545 stars 68 forks source link

Cannot run from docker #294

Closed StefanUlbrich closed 2 years ago

StefanUlbrich commented 2 years ago

Hi,

I followed the instruction for building the docker image.

When I run the alias, I get the following error:

Traceback (most recent call last):
  File "/usr/local/bin/comic_dl", line 10, in <module>
    from comic_dl.__version__ import __version__
  File "/opt/comic-dl/comic_dl/comic_dl.py", line 6, in <module>
    from .__version__ import __version__
ImportError: attempted relative import with no known parent package

Any idea what could cause the issue? Thanks

Xonshiz commented 2 years ago

Yeah, seems like import is still broken for python. You could try running it from cli.py, but I think it'll have its own issues. I'll have to set up a docker myself to see what the issue is with imports. Python won't let me do a parent-level import and I have added a workaround for it.

I'll try to take some time out and fix it in the upcoming weeks.

StefanUlbrich commented 2 years ago

Thanks for the answer. I prepared a fix for the problem in #295 (learned a bit more docker along the way :-) ) Enjoy the time out / vacation!

Xonshiz commented 2 years ago

Thanks a ton Stefan! Just merged that fix :) P.S: Not on vacation, just busy with some work hahaha.

StefanUlbrich commented 2 years ago

Welcome. Thanks for the project btw!